From 945719f43eeb4efa8ffc73bd538b06a41c93e784 Mon Sep 17 00:00:00 2001
From: "James D. Forrester" <jforrester@wikimedia.org>
Date: Thu, 4 May 2017 15:17:29 -0700
Subject: [PATCH] build: Enable
 MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName

Change-Id: Ib1e607addcb13c8fced2058ef5a80a96c95ff31e
---
 VisualEditor.hooks.php | 4 ++--
 extension.json         | 6 +++---
 phpcs.xml              | 3 ---
 3 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index c7a779af72..db18ea2af2 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -38,7 +38,7 @@ class VisualEditorHooks {
 		}
 	}
 
-	public static function VisualEditorApiFactory( $main, $name ) {
+	public static function getVisualEditorApiFactory( $main, $name ) {
 		$config = ConfigFactory::getDefaultInstance()->makeConfig( 'visualeditor' );
 		$class = $name === 'visualeditor' ? 'ApiVisualEditor' : 'ApiVisualEditorEdit';
 		return new $class( $main, $name, $config );
@@ -447,7 +447,7 @@ class VisualEditorHooks {
 	 * @param RecentChange $rc
 	 * @return boolean true
 	 */
-	public static function onRecentChange_save( RecentChange $rc ) {
+	public static function onRecentChangeSave( RecentChange $rc ) {
 		$request = RequestContext::getMain()->getRequest();
 		if ( $request->getBool( 'veswitched' ) && $rc->mAttribs['rc_this_oldid'] ) {
 			$rc->addTags( 'visualeditor-switched' );
diff --git a/extension.json b/extension.json
index a8195abc27..ba1c6ab2fd 100644
--- a/extension.json
+++ b/extension.json
@@ -113,11 +113,11 @@
 	"APIModules": {
 		"visualeditor": {
 			"class": "ApiVisualEditor",
-			"factory": "VisualEditorHooks::VisualEditorApiFactory"
+			"factory": "VisualEditorHooks::getVisualEditorApiFactory"
 		},
 		"visualeditoredit": {
 			"class": "ApiVisualEditorEdit",
-			"factory": "VisualEditorHooks::VisualEditorApiFactory"
+			"factory": "VisualEditorHooks::getVisualEditorApiFactory"
 		}
 	},
 	"MessagesDirs": {
@@ -174,7 +174,7 @@
 			"VisualEditorHooks::onEditPageShowEditFormFields"
 		],
 		"RecentChange_save": [
-			"VisualEditorHooks::onRecentChange_save"
+			"VisualEditorHooks::onRecentChangeSave"
 		],
 		"BeforeInitialize": [
 			"VisualEditorHooks::onBeforeInitialize"
diff --git a/phpcs.xml b/phpcs.xml
index 74c5e66330..628b23521e 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -23,7 +23,4 @@
 	<rule ref="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment">
 		<severity>0</severity>
 	</rule>
-	<rule ref="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName">
-		<severity>0</severity>
-	</rule>
 </ruleset>