wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-27 12:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix getAnnotatedRange to return propper contained range.

Browse source 
Fixed tests

Change-Id: I305eb81644fb3c804455b4fc13bdabcce97ea471
This commit is contained in:
Rob Moen 2012-05-17 13:17:18 -07:00
parent 3eb31dae09
commit a937ad22f7
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
modules/ve2/dm/ve.dm.Document.js
View file

@ -412,11 +412,10 @@ ve.dm.Document.prototype.getAnnotatedRangeFromOffset = function ( offset, annota
}
}
while ( end < this.data.length ) {
end++;
if ( this.offsetContainsAnnotation(end, annotation ) === false ) {
end--;
break;
}
end++;
}
return new ve.Range( start, end );
};

4
tests/ve2/dm/ve.dm.Document.test.js
View file

@ -382,7 +382,7 @@ test( 'getAnnotatedRangeFromOffset', 1, function(){
],
'annotation': { 'type': 'bold' },
'offset': 3,
'expected': new ve.Range( 1, 4 )
'expected': new ve.Range( 1, 5 )
},
{
'msg': 'a linked',
@ -410,7 +410,7 @@ test( 'getAnnotatedRangeFromOffset', 1, function(){
],
'annotation': { 'type': 'link/internal' },
'offset': 3,
'expected': new ve.Range( 3, 6 )
'expected': new ve.Range( 3, 7 )
}
];