wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-25 06:46:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Allow inspectors to not show the delete button"

Browse source
This commit is contained in:
jenkins-bot 2013-08-14 19:39:08 +00:00 committed by Gerrit Code Review
parent 344d97d89c 599ad772ed
commit a692a64372
2 changed files with 24 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/ve-mw/ui/inspectors/ve.ui.MWExtensionInspector.js
View file

@ -31,6 +31,8 @@ ve.ui.MWExtensionInspector.static.nodeView = null;
ve.ui.MWExtensionInspector.static.nodeModel = null; ve.ui.MWExtensionInspector.static.nodeModel = null;
ve.ui.MWExtensionInspector.static.removeable = false;
/* Methods */ /* Methods */
/** /**

28
modules/ve/ui/ve.ui.Inspector.js
View file

@ -35,6 +35,15 @@ ve.inheritClass( ve.ui.Inspector, ve.ui.Window );
ve.ui.Inspector.static.titleMessage = 've-ui-inspector-title'; ve.ui.Inspector.static.titleMessage = 've-ui-inspector-title';
/**
* The inspector comes with a remove button
* @static
* @inheritable
* @property {boolean}
*/
ve.ui.Inspector.static.removeable = true;
/* Methods */ /* Methods */
/** /**
@ -52,9 +61,11 @@ ve.ui.Inspector.prototype.initialize = function () {
this.closeButton = new ve.ui.IconButtonWidget( { this.closeButton = new ve.ui.IconButtonWidget( {
'$$': this.$$, 'icon': 'previous', 'title': ve.msg( 'visualeditor-inspector-close-tooltip' ) '$$': this.$$, 'icon': 'previous', 'title': ve.msg( 'visualeditor-inspector-close-tooltip' )
} ); } );
this.removeButton = new ve.ui.IconButtonWidget( { if ( this.constructor.static.removeable ) {
'$$': this.$$, 'icon': 'remove', 'title': ve.msg( 'visualeditor-inspector-remove-tooltip' ) this.removeButton = new ve.ui.IconButtonWidget( {
} ); '$$': this.$$, 'icon': 'remove', 'title': ve.msg( 'visualeditor-inspector-remove-tooltip' )
} );
}
// Events // Events
this.$form.on( { this.$form.on( {
@ -62,12 +73,17 @@ ve.ui.Inspector.prototype.initialize = function () {
'keydown': ve.bind( this.onFormKeyDown, this ) 'keydown': ve.bind( this.onFormKeyDown, this )
} ); } );
this.closeButton.connect( this, { 'click': 'onCloseButtonClick' } ); this.closeButton.connect( this, { 'click': 'onCloseButtonClick' } );
this.removeButton.connect( this, { 'click': 'onRemoveButtonClick' } ); if ( this.constructor.static.removeable ) {
this.removeButton.connect( this, { 'click': 'onRemoveButtonClick' } );
}
// Initialization // Initialization
this.closeButton.$.addClass( 've-ui-inspector-closeButton' ); this.closeButton.$.addClass( 've-ui-inspector-closeButton' );
this.removeButton.$.addClass( 've-ui-inspector-removeButton' ); this.$head.prepend( this.closeButton.$ );
this.$head.prepend( this.closeButton.$ ).append( this.removeButton.$ ); if ( this.constructor.static.removeable ) {
this.removeButton.$.addClass( 've-ui-inspector-removeButton' );
this.$head.append( this.removeButton.$ );
}
this.$body.append( this.$form ); this.$body.append( this.$form );
}; };