wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 22:35:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Don't update image model twice"

Browse source
This commit is contained in:
jenkins-bot 2014-05-21 19:23:55 +00:00 committed by Gerrit Code Review
parent 82dc0cbb99 d8040dbffc
commit a66c3147cb
1 changed files with 1 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js
View file

@ -526,22 +526,11 @@ ve.ui.MWMediaEditDialog.prototype.applyChanges = function () {
this.imageModel.setAltText(
this.altTextInput.getValue()
);
this.imageModel.setCaptionDocument(
this.captionSurface.getSurface().getModel().getDocument()
);
if ( this.typeInput.getSelectedItem() ) {
this.imageModel.setType(
this.typeInput.getSelectedItem().getData()
);
}
if ( this.positionCheckbox.getValue() && this.positionInput.getSelectedItem() ) {
this.imageModel.setAlignment(
this.positionInput.getSelectedItem().getData()
);
}
this.imageModel.toggleBorder( this.borderCheckbox.getValue() );
// Check if the image node changed from inline to block or
// vise versa
if ( this.mediaNode.type !== this.imageModel.getImageNodeType() ) {