wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 18:39:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Try to use margin/padding instead of flex for template dialog

Browse source 
Proof of concept: while flex is – well – flexible, it feels like
this should be possible with some good old block containers and
margins. It's pixel-perfect in my test.

Bug: T288465
Change-Id: I1458900fff197e08ce318398524a3cf2b6b9ee2a
This commit is contained in:
Thiemo Kreuz 2021-08-30 17:38:36 +02:00 committed by Adam Wight
parent c1ce1e3d4b
commit a4dac831d9
2 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/ve-mw/ui/styles/dialogs/ve.ui.MWTransclusionDialog.css
View file

@ -228,7 +228,3 @@
color: #72777d;
margin: 8px 24px;
}
.ve-ui-mwTransclusionDialog-multipart-message {
margin: 20px;
}

17
modules/ve-mw/ui/styles/pages/ve.ui.MWTemplatePage-default.css
View file

@ -23,3 +23,20 @@
.ve-ui-mwTemplatePage-description-missing {
font-style: italic;
}
.ve-ui-mwTransclusionDialog-newSidebar .oo-ui-menuLayout-content > .oo-ui-bookletLayout-stackLayout {
/* Wo don't want anything to collapse left/right, so shouldn't use margin */
padding: 0 48px;
}
.ve-ui-mwTransclusionDialog-newSidebar .oo-ui-bookletLayout-stackLayout > .oo-ui-panelLayout,
.ve-ui-mwTransclusionDialog-newSidebar .ve-ui-mwTransclusionDialog-multipart-message {
/* This top/bottom margin is meant to collapse with the next one */
margin: 48px 0;
}
.ve-ui-mwTransclusionDialog-newSidebar .oo-ui-bookletLayout-stackLayout > .oo-ui-panelLayout,
.ve-ui-mwTransclusionDialog-newSidebar .ve-ui-mwParameterPage-info,
.ve-ui-mwTransclusionDialog-newSidebar .ve-ui-mwParameterPage-field {
padding: 0;
}