wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 02:23:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't call parent on SelectWidget focus event

Browse source 
This regression from Iaf089f4b271fd853b17c1aa7f5938510ea8f5431.

Not calling the parent here was is essential, because when clicking
the checkboxes this event will trigger the focus of the whole widget.

That's not what we want in this case though. Also it seems we don't
need any of the logic from the parent and can get rid of that
complexity.

Bug: T312855
Bug: T312856
Bug: T312924
Change-Id: Ib3a2eeeb6d519dfa1bb627049f6b3a4708017e86
This commit is contained in:
WMDE-Fisch 2022-07-13 15:27:24 +02:00
parent 83fbbba390
commit a4aa684308
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineParameterSelectWidget.js
View file

@ -168,8 +168,7 @@ ve.ui.MWTransclusionOutlineParameterSelectWidget.prototype.onFocus = function (
// When tabbing into the selection list, always highlight the set or first parameter. // When tabbing into the selection list, always highlight the set or first parameter.
this.highlightItem( currentItem || this.items[ 0 ] ); this.highlightItem( currentItem || this.items[ 0 ] );
} }
// Don't call the parent. It makes assumptions what should be done here.
ve.ui.MWTransclusionOutlineParameterSelectWidget.super.prototype.onFocus.call( this, e );
}; };
/** /**