From a2f859771285ad7bcbba2b82bd1df8ed3cf90827 Mon Sep 17 00:00:00 2001 From: David Lynch Date: Wed, 12 Jul 2017 10:29:54 -0500 Subject: [PATCH] DesktopArticleTarget.init: only show welcome dialog if page editable "Welcome to wikipedia, anyone can edit, we welcome all improvements. Start editing!" is a bit out of place when what you'll see after clicking "start editing" is "you can't edit this page". Bug: T138715 Change-Id: I9f655a5f12d4e45644bd01631c2d3131375d8e8f --- .../ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js | 1 + 1 file changed, 1 insertion(+) diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js index 2452098ca6..5d338b72b7 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js +++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js @@ -1043,6 +1043,7 @@ welcomeDialogLocalStorageValue = localStorage.getItem( 've-beta-welcome-dialog' ); } catch ( e ) {} if ( + pageCanLoadEditor && showWikitextWelcome && mw.config.get( 'wgVisualEditorConfig' ).showBetaWelcome && [ 'edit', 'submit' ].indexOf( mw.config.get( 'wgAction' ) ) !== -1 &&