wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 03:08:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Fix:Internal and External Link annotation widget"

Browse source
This commit is contained in:
jenkins-bot 2020-02-25 16:03:01 +00:00 committed by Gerrit Code Review
parent a0cf9cb9f6 d3292378cc
commit a2ceb67351
5 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
extension.json
View file

@ -1852,6 +1852,7 @@
], ],
"messages": [ "messages": [
"visualeditor-linkinspector-button-link-external", "visualeditor-linkinspector-button-link-external",
"visualeditor-linkinspector-button-link-internal",
"visualeditor-linkinspector-convert-link-isbn", "visualeditor-linkinspector-convert-link-isbn",
"visualeditor-linkinspector-convert-link-pmid", "visualeditor-linkinspector-convert-link-pmid",
"visualeditor-linkinspector-convert-link-rfc", "visualeditor-linkinspector-convert-link-rfc",

1
i18n/ve-mw/en.json
View file

@ -224,6 +224,7 @@
"visualeditor-generating-wikitext-progress": "Generating wikitext", "visualeditor-generating-wikitext-progress": "Generating wikitext",
"visualeditor-languages-tool": "Languages", "visualeditor-languages-tool": "Languages",
"visualeditor-linkinspector-button-link-external": "External site", "visualeditor-linkinspector-button-link-external": "External site",
"visualeditor-linkinspector-button-link-internal": "Search internal pages",
"visualeditor-linkinspector-convert-link-isbn": "Convert to ISBN link", "visualeditor-linkinspector-convert-link-isbn": "Convert to ISBN link",
"visualeditor-linkinspector-convert-link-pmid": "Convert to PMID link", "visualeditor-linkinspector-convert-link-pmid": "Convert to PMID link",
"visualeditor-linkinspector-convert-link-rfc": "Convert to RFC link", "visualeditor-linkinspector-convert-link-rfc": "Convert to RFC link",

1
i18n/ve-mw/qqq.json
View file

@ -242,6 +242,7 @@
"visualeditor-generating-wikitext-progress": "Label for progress bar shown while generating wikitext.", "visualeditor-generating-wikitext-progress": "Label for progress bar shown while generating wikitext.",
"visualeditor-languages-tool": "Tool for opening the languages links section of the meta dialog.\n{{Identical|Language}}", "visualeditor-languages-tool": "Tool for opening the languages links section of the meta dialog.\n{{Identical|Language}}",
"visualeditor-linkinspector-button-link-external": "Button label for entering an link to an external site.", "visualeditor-linkinspector-button-link-external": "Button label for entering an link to an external site.",
"visualeditor-linkinspector-button-link-internal": "Prompt users' with assitive technologies to search an internal page",
"visualeditor-linkinspector-convert-link-isbn": "Button label for converting a simple link to a ISBN magic link.", "visualeditor-linkinspector-convert-link-isbn": "Button label for converting a simple link to a ISBN magic link.",
"visualeditor-linkinspector-convert-link-pmid": "Button label for converting a simple link to a PMID magic link.", "visualeditor-linkinspector-convert-link-pmid": "Button label for converting a simple link to a PMID magic link.",
"visualeditor-linkinspector-convert-link-rfc": "Button label for converting a simple link to a RFC magic link.", "visualeditor-linkinspector-convert-link-rfc": "Button label for converting a simple link to a RFC magic link.",

5
modules/ve-mw/ui/widgets/ve.ui.MWExternalLinkAnnotationWidget.js
View file

@ -51,13 +51,16 @@ ve.ui.MWExternalLinkAnnotationWidget.static.getAnnotationFromText = function ( v
* @return {OO.ui.TextInputWidget} Text input widget * @return {OO.ui.TextInputWidget} Text input widget
*/ */
ve.ui.MWExternalLinkAnnotationWidget.static.createExternalLinkInputWidget = function ( config ) { ve.ui.MWExternalLinkAnnotationWidget.static.createExternalLinkInputWidget = function ( config ) {
return new OO.ui.TextInputWidget( $.extend( {}, config, { var inputWidget = new OO.ui.TextInputWidget( $.extend( {}, config, {
icon: 'linkExternal', icon: 'linkExternal',
type: 'url', type: 'url',
validate: function ( text ) { validate: function ( text ) {
return !!ve.init.platform.getExternalLinkUrlProtocolsRegExp().exec( text.trim() ); return !!ve.init.platform.getExternalLinkUrlProtocolsRegExp().exec( text.trim() );
} }
} ) ); } ) );
inputWidget.$input.attr( 'aria-label', mw.msg( 'visualeditor-linkinspector-button-link-external' ) );
return inputWidget;
}; };
/* Methods */ /* Methods */

1
modules/ve-mw/ui/widgets/ve.ui.MWInternalLinkAnnotationWidget.js
View file

@ -74,6 +74,7 @@ ve.ui.MWInternalLinkAnnotationWidget.prototype.createInputWidget = function ( co
// override maxLength config option, because that would break the validation). // override maxLength config option, because that would break the validation).
input.getQuery().$input.removeAttr( 'maxlength' ); input.getQuery().$input.removeAttr( 'maxlength' );
input.query.$input.attr( 'aria-label', mw.msg( 'visualeditor-linkinspector-button-link-internal' ) );
return input; return input;
}; };