wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-19 09:41:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "EditCheck: Only pause if check is not rejected"

Browse source
This commit is contained in:
jenkins-bot 2024-12-13 16:46:33 +00:00 committed by Gerrit Code Review
parent 0e643b39bf fccb247285
commit a1bf3308a0
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
editcheck/modules/EditCheckDialog.js
View file

@ -323,13 +323,17 @@ ve.ui.EditCheckDialog.prototype.onAct = function ( widget, choice, actionChosen,
} }
if ( this.listener === 'onBeforeSave' ) { if ( this.listener === 'onBeforeSave' ) {
// We must have been acting on the currentOffset // If an action has been taken, we want to linger for a brief moment
// to show the result of the action before moving away
// TODO: This was written for AddReferenceEditCheck but should be
// more generic
const pause = data.action !== 'reject' ? 500 : 0;
setTimeout( () => { setTimeout( () => {
// We want to linger for a brief moment before moving away // We must have been acting on the currentOffset
this.currentChecks.splice( this.currentOffset, 1 ); this.currentChecks.splice( this.currentOffset, 1 );
this.currentOffset = Math.max( 0, this.currentOffset - 1 ); this.currentOffset = Math.max( 0, this.currentOffset - 1 );
this.update(); this.update();
}, 500 ); }, pause );
} }
} ); } );
}; };