From 0ab28904e68701440f370bfd730abbd8a84537a0 Mon Sep 17 00:00:00 2001
From: Ed Sanders <esanders@wikimedia.org>
Date: Tue, 25 Nov 2014 14:17:53 +0000
Subject: [PATCH] Fix rounded corners issue on help button by destroying
 notices

Empty this.$element in notices when there are no elements to display
as just hiding with CSS makes other items in the group no the last
child and therefore breaks any CSS rounded corners rules.

As notices are only ever generated at load, destroying the tool
is not a problem.

Bug: T63575
Change-Id: I63a044ca63f61b976f57e34ce9537034e68a2614
---
 modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js b/modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
index ff40b259b5..7686f2a7cd 100644
--- a/modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
+++ b/modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
@@ -47,7 +47,7 @@ ve.ui.MWNoticesPopupTool = function VeUiMWNoticesPopupTool( toolGroup, config )
 			this.popup.toggle( true );
 		}.bind( this ), 500 );
 	} else {
-		this.$element.hide();
+		this.$element = $( [] );
 	}
 };