wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 22:35:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ve.ce.BranchNode: Use DOM rather than jQuery in #onSplice"

Browse source
This commit is contained in:
jenkins-bot 2013-06-23 03:11:56 +00:00 committed by Gerrit Code Review
parent 3327f0fa7d d9fb612538
commit 9f3b36da7a
1 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
modules/ve/ce/ve.ce.BranchNode.js
View file

@ -149,10 +149,14 @@ ve.ce.BranchNode.prototype.onModelUpdate = function ( transaction ) {
* @param {ve.dm.BranchNode...} [nodes] Variadic list of nodes to insert
*/
ve.ce.BranchNode.prototype.onSplice = function ( index ) {
var i,
var i, j,
length,
args = Array.prototype.slice.call( arguments ),
$anchor,
afterAnchor,
node,
parentNode,
firstChild,
removals;
// Convert models to views and attach them to this node
if ( args.length >= 3 ) {
@ -176,9 +180,19 @@ ve.ce.BranchNode.prototype.onSplice = function ( index ) {
for ( i = args.length - 1; i >= 2; i-- ) {
args[i].attach( this );
if ( index ) {
$anchor.after( args[i].$ );
// DOM equivalent of $anchor.after( args[i].$ );
afterAnchor = $anchor[0].nextSibling;
parentNode = $anchor[0].parentNode;
for ( j = 0, length = args[i].$.length; j < length; j++ ) {
parentNode.insertBefore( args[i].$[j], afterAnchor );
}
} else {
this.$.prepend( args[i].$ );
// DOM equivalent of this.$.prepend( args[j].$ );
node = this.$[0];
firstChild = node.firstChild;
for ( j = args[i].$.length - 1; j >= 0; j-- ) {
node.insertBefore( args[i].$[j], firstChild );
}
}
if ( this.live !== args[i].isLive() ) {
args[i].setLive( this.live );