wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-29 00:30:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix save dialog crash on load error

Browse source 
If there was an error loading the HTML from Parsoid, ViewPageTarget
would try to tear down the save dialog, which caused a crash because
the save dialog doesn't exist yet at that point.

Change-Id: Ia50756a19cb775be96b90e87b642eb2a38f254ce
This commit is contained in:
Roan Kattouw 2013-10-22 01:15:35 +02:00
parent 324b04137b
commit 9d915aca2d
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
View file

@ -196,8 +196,11 @@ ve.init.mw.ViewPageTarget.prototype.deactivate = function ( override ) {
this.detachToolbarButtons(); this.detachToolbarButtons();
} }
this.saveDialog.reset(); if ( this.saveDialog ) {
this.saveDialog.close(); // If we got as far as setting up the save dialog, tear it down
this.saveDialog.reset();
this.saveDialog.close();
}
// Check we got as far as setting up the surface // Check we got as far as setting up the surface
if ( this.active ) { if ( this.active ) {
// If we got as far as setting up the surface, tear that down // If we got as far as setting up the surface, tear that down