diff --git a/includes/ApiVisualEditor.php b/includes/ApiVisualEditor.php index 65dc34bcde..f4bd1eda0a 100644 --- a/includes/ApiVisualEditor.php +++ b/includes/ApiVisualEditor.php @@ -508,12 +508,6 @@ class ApiVisualEditor extends ApiBase { )->parseAsBlock(), ]; } - - if ( $this->getConfig()->get( 'EnableBlockNoticeStats' ) ) { - $statsd = MediaWikiServices::getInstance()->getStatsdDataFactory(); - $wiki = $this->getConfig()->get( 'DBname' ); - $statsd->increment( 'BlockNotices.' . $wiki . '.VisualEditor.returned' ); - } } // HACK: Build a fake EditPage so we can get checkboxes from it diff --git a/includes/VisualEditorHooks.php b/includes/VisualEditorHooks.php index 365e40d003..586373e20b 100644 --- a/includes/VisualEditorHooks.php +++ b/includes/VisualEditorHooks.php @@ -925,7 +925,6 @@ class VisualEditorHooks { 'feedbackApiUrl' => $veConfig->get( 'VisualEditorFeedbackAPIURL' ), 'feedbackTitle' => $veConfig->get( 'VisualEditorFeedbackTitle' ), 'sourceFeedbackTitle' => $veConfig->get( 'VisualEditorSourceFeedbackTitle' ), - 'enableBlockNoticeStats' => $coreConfig->get( 'EnableBlockNoticeStats' ), ]; } diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js index 543e0d49f1..2ff4dbe0fc 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js +++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js @@ -1465,7 +1465,7 @@ ve.init.mw.DesktopArticleTarget.prototype.maybeShowMetaDialog = function () { // Pop out the notices when the welcome dialog is closed this.welcomeDialogPromise .always( function () { - var popup, wiki; + var popup; if ( target.switched && !mw.user.options.get( 'visualeditor-hidevisualswitchpopup' ) @@ -1477,14 +1477,6 @@ ve.init.mw.DesktopArticleTarget.prototype.maybeShowMetaDialog = function () { } else if ( target.actionsToolbar.tools.notices ) { // Show notices target.actionsToolbar.tools.notices.getPopup().toggle( true ); - if ( mw.config.get( 'wgVisualEditorConfig' ).enableBlockNoticeStats && - target.actionsToolbar.tools.notices.noticeItems.some( function ( item ) { - return item.type === 'block'; - } ) - ) { - wiki = mw.config.get( 'wgDBname' ); - mw.track( 'counter.MediaWiki.BlockNotices.' + wiki + '.VisualEditor.shown', 1 ); - } } } ); }