wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 11:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Throw an error for bad offsets in getNodeFromOffset()

Browse source 
Will ease debugging of bug 40463

Change-Id: I3fbacb3e6e2f242c1584f51581d2b4e7c4bdd4dc
This commit is contained in:
Catrope 2012-10-01 11:23:39 -07:00
parent d9570ed0e5
commit 9488a38cca
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
modules/ve/dm/ve.dm.Document.js
View file

@ -453,6 +453,9 @@ ve.dm.Document.prototype.getLength = function () {
ve.dm.Document.prototype.getNodeFromOffset = function ( offset ) { ve.dm.Document.prototype.getNodeFromOffset = function ( offset ) {
// FIXME duplicated from ve.ce.Document // FIXME duplicated from ve.ce.Document
if ( offset < 0 || offset > this.data.length ) {
throw new Error( 've.dm.Document.getNodeFromOffset(): offset ' + offset + ' is out of bounds' );
}
var node = this.documentNode.getNodeFromOffset( offset ); var node = this.documentNode.getNodeFromOffset( offset );
if ( !node.canHaveChildren() ) { if ( !node.canHaveChildren() ) {
node = node.getParent(); node = node.getParent();