wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 16:20:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

ve.ui.MWMediaResultWidget: Use .on() instead of .error()

Browse source 
> JQMIGRATE: jQuery.fn.error() is deprecated.

While at it, also avoid using the overloaded .load(). It has
quite a few different signatures (one of them is to load $.ajax
by url and replace the contents of the element, completely
unrelated), and calling .on() directly is quicker as well.

Change-Id: I139b0c603577b5a0102d2ff679bd86b792830e3e
This commit is contained in:
Timo Tijhof 2014-05-07 20:21:52 +02:00
parent 610f41e06a
commit 9455e1f3ab
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
modules/ve-mw/ui/widgets/ve.ui.MWMediaResultWidget.js
View file

@ -78,9 +78,11 @@ ve.ui.MWMediaResultWidget.prototype.buildThumbnail = function () {
$thumb = $back.add( $front );
// Preload image
$image
.load( ve.bind( this.onThumbnailLoad, this ) )
.error( ve.bind( this.onThumbnailError, this ) );
$image.on( {
'load': ve.bind( this.onThumbnailLoad, this ),
'error': ve.bind( this.onThumbnailError, this )
} );
image.src = info.thumburl;
$thumb.addClass( 've-ui-mwMediaResultWidget-thumbnail' );