wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-30 17:14:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix unchecked array access in ApiVisualEditor

Browse source 
I'm not sure if this qualifies as an actual fix. I don't really know
what this code is supposed to do. Maybe the bad array access is a hint
for a completely different error somewhere else. All this patch really
does is silencing the bad array access.

This line of code was introduced with I1b35b28 in May already. Why does
it start failing now?

Bug: T240961
Change-Id: I5ec2dc453e5d8db5d2f9e49058eda001ed021d3d
This commit is contained in:
Thiemo Kreuz 2019-12-18 08:22:25 +01:00
parent 5a24e78616
commit 8e4dc67ec7
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/ApiVisualEditor.php
View file

@ -626,7 +626,7 @@ class ApiVisualEditor extends ApiBase {
'blockinfo' => $blockinfo,
'canEdit' => $canEdit,
];
if ( $restbaseHeaders ) {
if ( isset( $restbaseHeaders['etag'] ) ) {
$result['etag'] = $restbaseHeaders['etag'];
}
if ( isset( $params['badetag'] ) ) {