wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-25 06:46:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add required indicators to parameter pages

Browse source 
Change-Id: I235af5feb1e02805f7844e51c9b1608341336749
This commit is contained in:
Trevor Parscal 2014-03-06 14:00:43 -08:00 committed by Jforrester
parent 763c203821
commit 8940bc1e69
2 changed files with 22 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
View file

@ -29,6 +29,7 @@ ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config )
this.$label = this.$( '<div>' );
this.$field = this.$( '<div>' );
this.$actions = this.$( '<div>' );
this.$indicators = this.$( '<div>' );
this.$info = this.$( '<div>' );
this.$description = this.$( '<div>' );
this.$more = this.$( '<div>' );
@ -56,6 +57,7 @@ ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config )
'tabIndex': -1
} )
.connect( this, { 'click': 'onAddButtonClick' } );
this.requiredIndicator = new OO.ui.IndicatorWidget( { '$': this.$ } );
// TODO: Use spec.deprecation
// TODO: Use spec.type
@ -71,6 +73,9 @@ ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config )
this.$actions
.addClass( 've-ui-mwParameterPage-actions' )
.append( this.removeButton.$element );
this.$indicators
.addClass( 've-ui-mwParameterPage-indicators' )
.append( this.requiredIndicator.$element );
this.$description
.addClass( 've-ui-mwParameterPage-description' )
.text( this.spec.getParameterDescription( paramName ) || '' );
@ -79,13 +84,21 @@ ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config )
.append( this.$description );
this.$field
.addClass( 've-ui-mwParameterPage-field' )
.append( this.valueInput.$element, this.$actions, this.$info );
.append( this.valueInput.$element, this.$indicators, this.$actions, this.$info );
this.$more
.addClass( 've-ui-mwParameterPage-more' )
.append( this.addButton.$element );
this.$element
.addClass( 've-ui-mwParameterPage' )
.append( this.$label, this.$field, this.$more );
if ( this.parameter.isRequired() ) {
this.requiredIndicator
.setIndicator( 'required' )
.setIndicatorTitle(
ve.msg( 'visualeditor-dialog-transclusion-required-parameter' )
);
}
};
/* Inheritance */

11
modules/ve-mw/ui/styles/ve.ui.MWPage.css
View file

@ -24,6 +24,7 @@
.ve-ui-mwParameterPage-field,
.ve-ui-mwParameterPage-info,
.ve-ui-mwParameterPage-actions,
.ve-ui-mwParameterPage-indicators,
.ve-ui-mwParameterPage .oo-ui-textInputWidget {
display: inline-block;
vertical-align: top;
@ -46,20 +47,24 @@
}
.ve-ui-mwParameterPage .oo-ui-textInputWidget {
width: 90%;
width: 86%;
}
.ve-ui-mwParameterPage .oo-ui-textInputWidget textarea {
height: 2.5em;
}
.ve-ui-mwParameterPage-indicators,
.ve-ui-mwParameterPage-actions {
display: none;
width: 10%;
width: 7%;
padding: 0.33em 0;
text-align: right;
}
.ve-ui-mwParameterPage-actions {
display: none;
}
.ve-ui-mwParameterPage.oo-ui-pageLayout-active .ve-ui-mwParameterPage-actions {
display: inline-block;
}