From 889ffc0efc3d4699a9d516d579b89d957a43d734 Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Wed, 11 Jan 2017 10:10:03 -0800 Subject: [PATCH] DesktopArticleTarget: Prevent infinite while loop if $content is empty Change-Id: I629b2c3f1a4af3441764db7d1d0a7cec96181396 --- modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js index a4eb73d720..d035055750 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js +++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js @@ -1258,7 +1258,7 @@ ve.init.mw.DesktopArticleTarget.prototype.transformPage = function () { // Mark every non-direct ancestor between editableContent and the container as uneditable $content = this.$editableContent; - while ( $content && !$content.parent().is( this.$container ) ) { + while ( $content && $content.length && !$content.parent().is( this.$container ) ) { $content.prevAll().addClass( 've-init-mw-desktopArticleTarget-uneditableContent' ); $content.nextAll().addClass( 've-init-mw-desktopArticleTarget-uneditableContent' ); $content = $content.parent();