wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "DiffPage: Only set user pref on 'choose' event"

Browse source
This commit is contained in:
jenkins-bot 2022-01-08 01:33:31 +00:00 committed by Gerrit Code Review
parent 67aad36acb 40a50cac4a
commit 8886773548
1 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
modules/ve-mw/preinit/ve.init.mw.DiffPage.init.js
View file

@ -42,11 +42,6 @@
var mode = item.getData();
var isVisual = mode === 'visual';
if ( mode !== mw.user.options.get( 'visualeditor-diffmode-historical' ) ) {
mw.user.options.set( 'visualeditor-diffmode-historical', mode );
// Same as ve.init.target.getLocalApi()
new mw.Api().saveOption( 'visualeditor-diffmode-historical', mode );
}
$visualDiffContainer.toggleClass( 'oo-ui-element-hidden', !isVisual );
$wikitextDiffBody.toggleClass( 'oo-ui-element-hidden', isVisual );
var $revSlider = $( '.mw-revslider-container' );
@ -100,6 +95,15 @@
}
function onReviewModeButtonSelectChoose( item ) {
var mode = item.getData();
if ( mode !== mw.user.options.get( 'visualeditor-diffmode-historical' ) ) {
mw.user.options.set( 'visualeditor-diffmode-historical', mode );
// Same as ve.init.target.getLocalApi()
new mw.Api().saveOption( 'visualeditor-diffmode-historical', mode );
}
}
mw.hook( 'wikipage.diff' ).add( function () {
$wikitextDiffContainer = $( 'table.diff[data-mw="interface"]' );
$wikitextDiffHeader = $wikitextDiffContainer.find( 'tr.diff-title' )
@ -115,7 +119,10 @@
new OO.ui.ButtonOptionWidget( { data: 'source', icon: 'wikiText', label: mw.msg( 'visualeditor-savedialog-review-wikitext' ) } )
]
} );
// Choose is only emitted when the user interacts with the widget, whereas
// select is emitted even when the mode is set programmatically (e.g. on load)
reviewModeButtonSelect.on( 'select', onReviewModeButtonSelectSelect );
reviewModeButtonSelect.on( 'choose', onReviewModeButtonSelectChoose );
$( '.ve-init-mw-diffPage-diffMode' ).empty().append( reviewModeButtonSelect.$element );
reviewModeButtonSelect.selectItemByData( initMode );
} );