From e1b4321b5a32a829048700a28b04ac375b8c3352 Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Fri, 16 Jun 2017 18:18:16 -0700 Subject: [PATCH] Return nothing from styleParsoidElements The method modifies DOM elements in place, and the return value is never used. Change-Id: I6254389dbf8daa67795206cb508038b60e1a4761 --- modules/ve-mw/init/ve.init.mw.LinkCache.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/modules/ve-mw/init/ve.init.mw.LinkCache.js b/modules/ve-mw/init/ve.init.mw.LinkCache.js index 472af3a2a0..cfdca0c48e 100644 --- a/modules/ve-mw/init/ve.init.mw.LinkCache.js +++ b/modules/ve-mw/init/ve.init.mw.LinkCache.js @@ -107,10 +107,8 @@ ve.init.mw.LinkCache.prototype.styleElement = function ( title, $element, hasFra * TODO: Most/all of this code should be done upstream, either by Parsoid itself or by an * intermediary service – see T64803 and others. * - * @chainable * @param {jQuery} $element Elements to style * @param {HTMLDocument} doc Base document to use for normalisation - * @return {jQuery} The elements, now styled */ ve.init.mw.LinkCache.prototype.styleParsoidElements = function ( $elements, doc ) { // TODO: Remove when fixed upstream in Parsoid (T58756) @@ -133,8 +131,6 @@ ve.init.mw.LinkCache.prototype.styleParsoidElements = function ( $elements, doc ve.init.platform.linkCache.styleElement( title, $( this ) ); } ); } - - return $elements; }; /**