wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-13 17:48:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ApiVisualEditorEdit: Remove unused output values 'basetimestamp', 'starttimestamp'"

Browse source
This commit is contained in:
jenkins-bot 2020-03-20 19:37:47 +00:00 committed by Gerrit Code Review
parent 316161de03 9e859a6145
commit 8384559296
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
includes/ApiVisualEditorEdit.php
View file

@ -108,8 +108,6 @@ class ApiVisualEditorEdit extends ApiVisualEditor {
] );
$content = $result['parse']['text']['*'] ?? false;
$categorieshtml = $result['parse']['categorieshtml']['*'] ?? false;
$revision = Revision::newFromId( $result['parse']['revid'] );
$timestamp = $revision ? $revision->getTimestamp() : wfTimestampNow();
$displaytitle = $result['parse']['displaytitle'] ?? false;
$modules = array_merge(
$result['parse']['modules'] ?? [],
@ -117,7 +115,11 @@ class ApiVisualEditorEdit extends ApiVisualEditor {
);
$jsconfigvars = $result['parse']['jsconfigvars'] ?? [];
if ( $content === false || ( strlen( $content ) && $revision === null ) ) {
if (
$content === false ||
// TODO: Is this check still needed?
( strlen( $content ) && Revision::newFromId( $result['parse']['revid'] ) === null )
) {
return false;
}
@ -130,8 +132,6 @@ class ApiVisualEditorEdit extends ApiVisualEditor {
return [
'content' => $content,
'categorieshtml' => $categorieshtml,
'basetimestamp' => $timestamp,
'starttimestamp' => wfTimestampNow(),
'displayTitleHtml' => $displaytitle,
'modules' => $modules,
'jsconfigvars' => $jsconfigvars