wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 08:10:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Efficiency improvement for MWLanguageVariantNode#hasRendering"

Browse source
This commit is contained in:
jenkins-bot 2017-10-13 21:02:55 +00:00 committed by Gerrit Code Review
parent a0d39d3643 b56e7eec4d
commit 82c8e64f8f
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
modules/ve-mw/ce/nodes/ve.ce.MWLanguageVariantNode.js
View file

@ -162,6 +162,16 @@ ve.ce.MWLanguageVariantNode.prototype.createInvisibleIcon = function () {
return icon.$element; return icon.$element;
}; };
/**
* @inheritdoc
*/
ve.ce.MWLanguageVariantNode.prototype.hasRendering = function () {
// Efficiency improvement: the superclass implementation does a bunch
// of DOM measurement to determine if the node is empty.
// Instead consult the model for a definitive answer.
return !this.model.isHidden();
};
/** /**
* ContentEditable MediaWiki language variant block node. * ContentEditable MediaWiki language variant block node.
* *