wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 06:24:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Order template title results by provided index

Browse source 
This only comes back in results from certain modules, so I'm not entirely
sure whether we want to do this in here or mw.widgets.TitleInputWidget.

Bug: T111598
Change-Id: If2916706db359d520c41c2dec7ded44e0d3a56a9
This commit is contained in:
Alex Monk 2015-09-10 17:13:36 +01:00
parent 2fcf6b7ce7
commit 821ceb9920
1 changed files with 30 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
modules/ve-mw/ui/widgets/ve.ui.MWTemplateTitleInputWidget.js
View file

@ -51,18 +51,42 @@ ve.ui.MWTemplateTitleInputWidget.prototype.getLookupRequest = function () {
if ( this.showTemplateDescriptions ) {
return promise
// Also get descriptions
.then( function ( response ) {
var xhr, index, params,
pages = ( response.query && response.query.pages ) || {},
var xhr, pageId, index, params, indexFound, redirIndex,
redirects = ( response.query && response.query.redirects ) || {},
origPages = ( response.query && response.query.pages ) || {},
newPages = [],
titles = [];
for ( index in pages ) {
titles.push( pages[ index ].title );
// Build a new array to replace response.query.pages, ensuring everything goes into
// the order defined by the page's index key, instead of whatever random order the
// browser would let you iterate over the old object in.
for ( pageId in origPages ) {
indexFound = false;
if ( 'index' in origPages[ pageId ] ) {
newPages[ origPages[ pageId ].index - 1 ] = origPages[ pageId ];
indexFound = true;
} else {
// Watch out for cases where the index is specified on the redirect object
// rather than the page object.
for ( redirIndex in redirects ) {
if ( redirects[ redirIndex ].to === origPages[ pageId ].title ) {
newPages[ redirects[ redirIndex ].index - 1 ] = origPages[ pageId ];
indexFound = true;
break;
}
}
}
}
originalResponse = response;
for ( index in newPages ) {
titles.push( newPages[ index ].title );
}
response.query.pages = newPages;
originalResponse = response; // lie!
// Also get descriptions
if ( titles.length > 0 ) {
params = {
action: 'templatedata',