From 80ab08a1cd19cee29cb6e7f65b456989905691fa Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Tue, 17 Dec 2024 15:40:26 +0000 Subject: [PATCH] EditCheck: Only preserve native selection on desktop On mobile, we need to deactivate the surface so that the checks are visible where the virtual keyboard would be. Change-Id: Ib108f8a0abb6fe9b503ac394188d3468f9a316cb --- editcheck/modules/EditCheckDialog.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/editcheck/modules/EditCheckDialog.js b/editcheck/modules/EditCheckDialog.js index a4583007f7..59698ac8b2 100644 --- a/editcheck/modules/EditCheckDialog.js +++ b/editcheck/modules/EditCheckDialog.js @@ -36,7 +36,8 @@ ve.ui.EditCheckDialog.static.size = OO.ui.isMobile() ? 'full' : 'medium'; ve.ui.EditCheckDialog.static.framed = false; -ve.ui.EditCheckDialog.static.activeSurface = true; +// TODO: Keep surface active on mobile for some checks? +ve.ui.EditCheckDialog.static.activeSurface = !OO.ui.isMobile(); // Invisible title for accessibility ve.ui.EditCheckDialog.static.title = OO.ui.deferMsg( 'editcheck-review-title' );