wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Streamline button margin calculation for outline parts

Browse source 
Generally the default button margin on the parts is 24px. The only
exception are the placeholder and wikitext when they are the last
parts in the outline.

Bug: T312644
Change-Id: Ie513bf1c022b2696cc92aacbbca59ddf6e55043e
This commit is contained in:
WMDE-Fisch 2022-08-02 15:02:02 +02:00
parent cdf9a59278
commit 7f4645bbe0
3 changed files with 7 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
modules/ve-mw/ui/styles/widgets/ve.ui.MWTransclusionOutlineWidget.less
View file

@ -29,19 +29,9 @@
margin-top: -24px; margin-top: -24px;
} }
/* no margin for labels and wikitext */ &:last-child.ve-ui-mwTransclusionOutlineWikitextWidget,
&:last-child { &:last-child.ve-ui-mwTransclusionOutlinePlaceholderWidget {
margin-bottom: -24px; margin-bottom: 0;
/* margin for last text */
.ve-ui-mwTransclusionOutlineTemplateWidget-no-template-parameters {
margin-bottom: 48px;
}
/* margin for last checkbox in the sidebar */
.ve-ui-mwTransclusionOutlineParameterWidget:last-child {
margin-bottom: 48px;
}
} }
.ve-ui-mwTransclusionOutlineButtonWidget { .ve-ui-mwTransclusionOutlineButtonWidget {

2
modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlinePlaceholderWidget.js
View file

@ -18,6 +18,8 @@ ve.ui.MWTransclusionOutlinePlaceholderWidget = function VeUiMWTransclusionOutlin
icon: 'puzzle', icon: 'puzzle',
label: label label: label
} ); } );
this.$element.addClass( 've-ui-mwTransclusionOutlinePlaceholderWidget' );
}; };
/* Inheritance */ /* Inheritance */

2
modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineWikitextWidget.js
View file

@ -17,6 +17,8 @@ ve.ui.MWTransclusionOutlineWikitextWidget = function VeUiMWTransclusionOutlineWi
ariaDescriptionSelected: ve.msg( 'visualeditor-dialog-transclusion-wikitext-widget-aria-selected' ), ariaDescriptionSelected: ve.msg( 'visualeditor-dialog-transclusion-wikitext-widget-aria-selected' ),
ariaDescriptionSelectedSingle: ve.msg( 'visualeditor-dialog-transclusion-wikitext-widget-aria-selected-single' ) ariaDescriptionSelectedSingle: ve.msg( 'visualeditor-dialog-transclusion-wikitext-widget-aria-selected-single' )
} ); } );
this.$element.addClass( 've-ui-mwTransclusionOutlineWikitextWidget' );
}; };
/* Inheritance */ /* Inheritance */