wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't wrap unknown actions with confirmation

Browse source 
For example, the "apply changes" button was producing a confirmation
dialog.

Bug: T300095
Change-Id: I77e53cc0cf62ff7c0aca052568384e20490ce7ec
This commit is contained in:
Adam Wight 2022-01-26 14:40:58 +01:00
parent e4cd36b471
commit 7e7ad97bf6
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
View file

@ -439,7 +439,7 @@ ve.ui.MWTransclusionDialog.prototype.getActionProcess = function ( action ) {
return new OO.ui.Process( function () { return new OO.ui.Process( function () {
this.toggleSidebar( !this.isSidebarExpanded ); this.toggleSidebar( !this.isSidebarExpanded );
}, this ); }, this );
default: case '':
// close action // close action
if ( willLoseProgress ) { if ( willLoseProgress ) {
return new OO.ui.Process( function () { return new OO.ui.Process( function () {
@ -447,10 +447,9 @@ ve.ui.MWTransclusionDialog.prototype.getActionProcess = function ( action ) {
'visualeditor-dialog-transclusion-close-confirmation-prompt', 'visualeditor-dialog-transclusion-close-confirmation-prompt',
this.close.bind( this ) ); this.close.bind( this ) );
}, this ); }, this );
} else {
return ve.ui.MWTransclusionDialog.super.prototype.getActionProcess.call( this, action );
} }
} }
return ve.ui.MWTransclusionDialog.super.prototype.getActionProcess.call( this, action );
}; };
/** /**