wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 00:00:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a warning about $wgVisualEditorPluginModules race condition

Browse source 
Warn developers not to delist a plugin module and remove it in a single
deployment, since the relevant cache layers are not synchronized, making a race
condition possible. See I627a0d5d8 for an example.

Change-Id: I488bafa08a5eab6b40fa73bb5ca031fb5a6aa9ed
This commit is contained in:
Ori Livneh 2015-02-19 15:26:30 -08:00
parent f91974ed0f
commit 7e6eba0fe8
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
VisualEditor.php
View file

@ -1493,6 +1493,11 @@ $wgDefaultUserOptions['visualeditor-hidebetawelcome'] = 0;
// Array of ResourceLoader module names (strings) that should be loaded when VisualEditor is // Array of ResourceLoader module names (strings) that should be loaded when VisualEditor is
// loaded. Other extensions that extend VisualEditor should add to this array. // loaded. Other extensions that extend VisualEditor should add to this array.
//
// WARNING: When removing a module, first remove it from this array, wait for the change
// to propagate, and only then remove the module code and module registration. Otherwise
// there may be a period of time during which VisualEditor depends on a module that no
// longer exists.
$wgVisualEditorPluginModules = array(); $wgVisualEditorPluginModules = array();
// Array of modules to load based on a preference. Keys are preference names, values are // Array of modules to load based on a preference. Keys are preference names, values are