wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 22:35:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Delete default sort key if set to empty string

Browse source 
Bug: 49724
Change-Id: Ie3caaf4811f87911444462f83d511c0cc46c0716
This commit is contained in:
Ed Sanders 2013-06-21 11:48:20 +01:00
parent 1ea9016cf8
commit 7b1df21aeb
1 changed files with 16 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
modules/ve/ui/dialogs/ve.ui.MWMetaDialog.js
View file

@ -179,18 +179,22 @@ ve.ui.MWMetaDialog.prototype.onClose = function ( action ) {
}
if ( this.defaultSortKeyChanged ) {
newDefaultSortKeyItemData = {
'type': 'mwDefaultSort',
'attributes': { 'content': this.defaultSortInput.getValue() }
};
if ( currentDefaultSortKeyItem ) {
newDefaultSortKeyItem = new ve.dm.MWDefaultSortMetaItem(
ve.extendObject( {}, currentDefaultSortKeyItem.getElement(), newDefaultSortKeyItemData )
);
currentDefaultSortKeyItem.replaceWith( newDefaultSortKeyItem );
} else {
newDefaultSortKeyItem = new ve.dm.MWDefaultSortMetaItem( newDefaultSortKeyItemData );
this.metaList.insertMeta( newDefaultSortKeyItem );
if ( this.defaultSortInput.getValue() !== '' ) {
newDefaultSortKeyItemData = {
'type': 'mwDefaultSort',
'attributes': { 'content': this.defaultSortInput.getValue() }
};
if ( currentDefaultSortKeyItem ) {
newDefaultSortKeyItem = new ve.dm.MWDefaultSortMetaItem(
ve.extendObject( {}, currentDefaultSortKeyItem.getElement(), newDefaultSortKeyItemData )
);
currentDefaultSortKeyItem.replaceWith( newDefaultSortKeyItem );
} else {
newDefaultSortKeyItem = new ve.dm.MWDefaultSortMetaItem( newDefaultSortKeyItemData );
this.metaList.insertMeta( newDefaultSortKeyItem );
}
} else if ( currentDefaultSortKeyItem ) {
currentDefaultSortKeyItem.remove();
}
}