diff --git a/editcheck/modules/BaseEditCheck.js b/editcheck/modules/BaseEditCheck.js index 60e01899ce..169b5f71b4 100644 --- a/editcheck/modules/BaseEditCheck.js +++ b/editcheck/modules/BaseEditCheck.js @@ -62,8 +62,16 @@ mw.editcheck.BaseEditCheck.prototype.canBeShown = function () { return false; } // some checks are configured to only be for logged in / out users - if ( !mw.editcheck.accountShouldSeeEditCheck( this.config ) ) { - // includes checking for mw.editcheck.ecenable + if ( mw.editcheck.ecenable ) { + return true; + } + // account status: + // loggedin, loggedout, or any-other-value meaning 'both' + // we'll count temporary users as "logged out" by using isNamed here + if ( this.config.account === 'loggedout' && mw.user.isNamed() ) { + return false; + } + if ( this.config.account === 'loggedin' && !mw.user.isNamed() ) { return false; } // some checks are only shown for newer users diff --git a/editcheck/modules/init.js b/editcheck/modules/init.js index c8e35d66e3..6d35b03b74 100644 --- a/editcheck/modules/init.js +++ b/editcheck/modules/init.js @@ -10,22 +10,6 @@ require( './EditCheckFactory.js' ); require( './EditCheckAction.js' ); require( './BaseEditCheck.js' ); -mw.editcheck.accountShouldSeeEditCheck = function ( config ) { - if ( mw.editcheck.ecenable ) { - return true; - } - // account status: - // loggedin, loggedout, or any-other-value meaning 'both' - // we'll count temporary users as "logged out" by using isNamed here - if ( config.account === 'loggedout' && mw.user.isNamed() ) { - return false; - } - if ( config.account === 'loggedin' && !mw.user.isNamed() ) { - return false; - } - return true; -}; - // TODO: Load these checks behind feature flags // require( './ConvertReferenceEditCheck.js' ); // require( './TextMatchEditCheck.js' );