wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-01 09:26:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add section id to URI fragment on save

Browse source 
Bug: T181075
Change-Id: Iea63112301bfa0860c3d68efc35648a5af7e4ae6
This commit is contained in:
David Lynch 2017-12-13 11:55:18 -06:00 committed by DLynch
parent af8428e861
commit 6f2c829bd9
1 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
View file

@ -1292,7 +1292,7 @@ ve.init.mw.DesktopArticleTarget.prototype.updateHistoryState = function () {
* Page modifications for switching back to view mode. * Page modifications for switching back to view mode.
*/ */
ve.init.mw.DesktopArticleTarget.prototype.restorePage = function () { ve.init.mw.DesktopArticleTarget.prototype.restorePage = function () {
var uri, keys; var uri, keys, section, $section;
// Skins like monobook don't have a tab for view mode and instead just have the namespace tab // Skins like monobook don't have a tab for view mode and instead just have the namespace tab
// selected. We didn't deselect the namespace tab, so we're ready after deselecting #ca-ve-edit. // selected. We didn't deselect the namespace tab, so we're ready after deselecting #ca-ve-edit.
@ -1316,6 +1316,24 @@ ve.init.mw.DesktopArticleTarget.prototype.restorePage = function () {
delete uri.query.veaction; delete uri.query.veaction;
} }
if ( 'section' in uri.query ) { if ( 'section' in uri.query ) {
// Translate into a fragment for the new URI:
// This should be after replacePageContent if this is post-save, so we can just look
// at the headers on the page.
section = uri.query.section.toString().indexOf( 'T-' ) === 0 ? +uri.query.section.slice( 2 ) : uri.query.section;
$section = this.$editableContent.find( 'h1, h2, h3, h4, h5, h6' )
// Ignore headings inside TOC
.filter( function () {
return $( this ).closest( '#toc' ).length === 0;
} );
if ( section === 'new' ) {
// A new section is appended to the end, so take the last one.
section = $section.length;
}
$section = $section.eq( section - 1 ).find( '.mw-headline' );
if ( $section.length && $section.attr( 'id' ) ) {
uri.fragment = $section.attr( 'id' );
}
delete uri.query.section; delete uri.query.section;
} }
if ( 'action' in uri.query && $( '#wpTextbox1' ).length === 0 ) { if ( 'action' in uri.query && $( '#wpTextbox1' ).length === 0 ) {