wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-23 10:19:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't set direction for editsections

Browse source 
This causes editsection to jump

Bug: T371665
Change-Id: Ia7dd8076c8789ed04d3fb52a078c70561ee5c6f8
This commit is contained in:
Ebrahim Byagowi 2024-08-02 10:55:51 +03:30
parent 57daf35bd6
commit 6965da7012
1 changed files with 2 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules/ve-mw/preinit/ve.init.mw.DesktopArticleTarget.init.js
View file

@ -1024,17 +1024,9 @@
* Setup multiple section links (edit + edit source)
*/
setupMultiSectionLinks: function () {
const $editsections = $( '#mw-content-text .mw-editsection' ),
bodyDir = $( document.body ).css( 'direction' );
// Match direction of the user interface
// TODO: Why is this needed? It seems to work fine without.
if ( $editsections.css( 'direction' ) !== bodyDir ) {
// Avoid creating inline style attributes if the inherited value is already correct
$editsections.css( 'direction', bodyDir );
}
if ( pageCanLoadEditor ) {
const $editsections = $( '#mw-content-text .mw-editsection' );
// Only init without refresh if we're on a view page. Though section edit links
// are rarely shown on non-view pages, they appear in one other case, namely
// when on a diff against the latest version of a page. In that case we mustn't