wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 08:10:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Rerender extension node immediately if no images exist"

Browse source
This commit is contained in:
jenkins-bot 2015-09-01 14:57:41 +00:00 committed by Gerrit Code Review
parent 6521b4a76e 519e029298
commit 65c073813e
1 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
modules/ve-mw/ce/nodes/ve.ce.MWExtensionNode.js
View file

@ -97,12 +97,20 @@ ve.ce.MWExtensionNode.prototype.onParseSuccess = function ( deferred, response )
/** */
ve.ce.MWExtensionNode.prototype.afterRender = function () {
var node = this;
// Rerender after images load
// TODO: ignore shields, and count multiple images
this.$element.find( 'img' ).on( 'load', function () {
node.emit( 'rerender' );
} );
var node = this,
$images = this.$element.find( 'img:not([width]),img:not([height])' );
// Images missing a dimension change size after load
// TODO: Ignore images which have dimensions defined in CSS, if performant
if ( $images.length ) {
$images.on( 'load', function () {
// Mixin method
ve.ce.GeneratedContentNode.prototype.afterRender.call( node );
} );
} else {
// Mixin method
ve.ce.GeneratedContentNode.prototype.afterRender.call( this );
}
};
/**