From 301b152ec8860b21edb1c8bb3fe7eb2061f795f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=BDeljko=20Filipin?= Date: Wed, 2 Mar 2016 13:31:23 +0100 Subject: [PATCH] [BrowserTest] Fix `ve.init is undefined` and `ve.init.target is undefined` error messages Looks like local browsers raise Selenium::WebDriver::Error::JavascriptError while remote (Sauce Labs) browsers raise Selenium::WebDriver::Error::UnknownError if a test tries to use an element but VisualEditor is not loaded. Bug: T126966 Change-Id: I89c8eaba996e95e7859084fe26e15befee9dce77 --- .../browser/features/support/pages/visual_editor_page.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb index 0917211063..5406de18b1 100644 --- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb @@ -205,11 +205,11 @@ class VisualEditorPage loop do begin browser.execute_script script - rescue Selenium::WebDriver::Error::JavascriptError => e + rescue Selenium::WebDriver::Error::JavascriptError, Selenium::WebDriver::Error::UnknownError => e else e = nil end - break unless e.class == Selenium::WebDriver::Error::JavascriptError + break unless (e.class == Selenium::WebDriver::Error::JavascriptError) || (e.class == Selenium::WebDriver::Error::UnknownError) end end browser.execute_script script