wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-12 09:09:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Preserve HTML attributes for textStyle/* annotations

Browse source 
The new annotation API will do this too; this is a temporary hack to fix
the bugs caused by stripping attributes.

This code doesn't actually render the attributes, but the new annotation
API will.

Change-Id: Ic0ddf822fe02f101f2e825080c6bcc2a03115974
This commit is contained in:
Catrope 2012-08-09 13:30:21 -07:00
parent fd3b2e5b10
commit 62d0858805
1 changed files with 19 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
modules/ve/dm/annotations/ve.dm.TextStyleAnnotation.js
View file

@ -29,7 +29,7 @@ ve.dm.TextStyleAnnotation = function () {
ve.dm.TextStyleAnnotation.converters = {
'domElementTypes': ['i', 'b', 'u', 's', 'small', 'big', 'span'],
'toDomElement': function ( subType, annotation ) {
return annotation.type && document.createElement( ( {
var map = {
'italic': 'i',
'bold': 'b',
'underline': 'u',
@ -42,11 +42,16 @@ ve.dm.TextStyleAnnotation.converters = {
'superScript': 'sup',
'subScript': 'sub'
// TODO: Add other supported inline DOM elements to this list
} )[subType] );
};
return $( document.createElement( map[subType] ) )
// Restore HTML attributes
// Will be done for us in the new annotation API
.attr( annotation.htmlAttributes )
.get( 0 );
},
'toDataAnnotation': function ( tag, element ) {
return {
'type': 'textStyle/' + ( {
var annotation, i, length,
map = {
'i': 'italic',
'b': 'bold',
'u': 'underline',
@ -59,8 +64,17 @@ ve.dm.TextStyleAnnotation.converters = {
'sup': 'superScript',
'sub': 'subScript'
// TODO: Add other supported inline DOM elements to this list
} )[tag]
};
annotation = {
type: 'textStyle/' + map[tag],
htmlAttributes: {}
};
// Preserve HTML attributes
// Will be done for us in the new annotation API
for ( i = 0, length = element.attributes.length; i < length; i++ ) {
annotation.htmlAttributes[element.attributes[i].name] = element.attributes[i].value;
}
return annotation;
}
};