From efbfcd8b358dc0c68656b6f3da735d4b186814ce Mon Sep 17 00:00:00 2001
From: David Lynch <dlynch@wikimedia.org>
Date: Wed, 29 Nov 2017 11:24:32 -0600
Subject: [PATCH] ui.MWSaveDialog: consistent handling of preview category
 links

Category links weren't being checked for redlink status, and weren't opening
in a new window.

Bug: T179913
Change-Id: Ic665583128bf51710178c5674cd35c273f5f207e
---
 modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
index a31a8be21e..0a2fecd4bc 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
@@ -203,9 +203,6 @@ ve.ui.MWSaveDialog.prototype.showPreview = function ( docOrMsg, baseDoc ) {
 
 		// TODO: This code is very similar to ve.ui.PreviewElement+ve.ui.MWPreviewElement
 		ve.resolveAttributes( body, docOrMsg, ve.dm.Converter.static.computedAttributes );
-		ve.targetLinksToNewWindow( body );
-		// Add styles so links render with their appropriate classes
-		ve.init.platform.linkCache.styleParsoidElements( $( body ), baseDoc );
 
 		// Remove metadata
 		contents = ve.filterMetaElements( Array.prototype.slice.call( body.childNodes ) );
@@ -223,12 +220,16 @@ ve.ui.MWSaveDialog.prototype.showPreview = function ( docOrMsg, baseDoc ) {
 					document.createTextNode( ve.msg( 'pagecategories', categories.length ) + ve.msg( 'colon-separator' ) ),
 					$( '<ul>' ).append( categories.map( function ( category ) {
 						var title = mw.Title.newFromText( category );
-						return $( '<li>' ).append( $( '<a>' ).attr( 'href', title.getUrl() ).text( title.getMainText() ) );
+						return $( '<li>' ).append( $( '<a>' ).attr( 'rel', 'mw:WikiLink' ).attr( 'href', title.getUrl() ).text( title.getMainText() ) );
 					} ) )
 				)
 			);
 		}
 
+		ve.targetLinksToNewWindow( this.$previewViewer[ 0 ] );
+		// Add styles so links render with their appropriate classes
+		ve.init.platform.linkCache.styleParsoidElements( this.$previewViewer, baseDoc );
+
 		// Run hooks so other things can alter the document
 		mw.hook( 'wikipage.content' ).fire( this.$previewViewer );
 	} else {