diff --git a/extension.json b/extension.json index f36e27db0f..4e220d4e84 100644 --- a/extension.json +++ b/extension.json @@ -2243,7 +2243,6 @@ "visualeditor-dialog-transclusion-deprecated-parameter", "visualeditor-dialog-transclusion-deprecated-parameter-description", "visualeditor-dialog-transclusion-expand-options", - "visualeditor-dialog-transclusion-feedback-message", "visualeditor-dialog-transclusion-filter-hide-unused", "visualeditor-dialog-transclusion-filter-no-match", "visualeditor-dialog-transclusion-filter-placeholder", diff --git a/i18n/ve-mw/en.json b/i18n/ve-mw/en.json index 1ee3660cf3..67ff2adaf2 100644 --- a/i18n/ve-mw/en.json +++ b/i18n/ve-mw/en.json @@ -246,7 +246,6 @@ "visualeditor-dialog-transclusion-template-search": "Template search", "visualeditor-dialog-transclusion-template-search-help": "Find the template you want to insert by searching for an identifying keyword. Templates that have descriptions are more likely to work well with the visual editor.", "visualeditor-dialog-transclusion-templates-menu-aria-label": "Template fields setup menu", - "visualeditor-dialog-transclusion-feedback-message": "Recent work was completed to improve template search results. To learn more about the changes or leave feedback, go to the [//meta.wikimedia.org/wiki/Special:MyLanguage/WMDE_Technical_Wishes/Finding_and_inserting_templates project's page].", "visualeditor-dialog-transclusion-wikitext": "Wikitext", "visualeditor-dialog-transclusion-wikitext-widget-aria": "Press Space to select the wikitext element. Press Enter to select and edit the wikitext.", "visualeditor-dialog-transclusion-wikitext-widget-aria-selected": "Press Ctrl+Del to delete the wikitext element. Press Ctrl+Shift+Arrows to move the element up or down.", diff --git a/i18n/ve-mw/qqq.json b/i18n/ve-mw/qqq.json index fabff1588b..38bdaf2157 100644 --- a/i18n/ve-mw/qqq.json +++ b/i18n/ve-mw/qqq.json @@ -266,7 +266,6 @@ "visualeditor-dialog-transclusion-template-search": "Dialog and fieldset label to search for a template.", "visualeditor-dialog-transclusion-template-search-help": "Inline help for the template search field.", "visualeditor-dialog-transclusion-templates-menu-aria-label": "ARIA label for screen readers on template fields setup menu.", - "visualeditor-dialog-transclusion-feedback-message": "Text for the feedback message to inform users about template search improvements with a link to the project page.", "visualeditor-dialog-transclusion-wikitext": "Label for editor of wikitext content between transclusion parts.", "visualeditor-dialog-transclusion-wikitext-widget-aria": "ARIA description for screen readers on the template parameter selection menu for the keyboard controls on unselected wikitext parts.", "visualeditor-dialog-transclusion-wikitext-widget-aria-selected": "ARIA description for screen readers on the template parameter selection menu for the keyboard controls on selected wikitext parts.", diff --git a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js index e0df24489f..7213148467 100644 --- a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js +++ b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js @@ -19,7 +19,6 @@ */ ve.ui.MWTemplatePlaceholderPage = function VeUiMWTemplatePlaceholderPage( placeholder, name, config ) { var veConfig = mw.config.get( 'wgVisualEditorConfig' ); - var page = this; // Configuration initialization config = ve.extendObject( { @@ -75,29 +74,13 @@ ve.ui.MWTemplatePlaceholderPage = function VeUiMWTemplatePlaceholderPage( placeh 'visualeditor-dialog-transclusion-template-search' : 'visualeditor-dialog-transclusion-add-template'; - // Temporary feedback message when templateSearchImprovements is true T284560 - // TODO: remove when templateSearchImprovements are out of beta - var key = 'mwe-visualeditor-hide-visualeditor-dialog-transclusion-feedback-message'; - var feedbackMessage = new OO.ui.MessageWidget( { - label: $( ve.htmlMsg( 'visualeditor-dialog-transclusion-feedback-message' ) ), - showClose: true - } ) - .on( 'close', function () { - mw.storage.set( key, '1' ); - page.focus(); - } ) - .toggle( !mw.storage.get( key ) ); - ve.targetLinksToNewWindow( feedbackMessage.$label[ 0 ] ); - addTemplateFieldsetConfig = ve.extendObject( addTemplateFieldsetConfig, { // The following messages are used here: // * visualeditor-dialog-transclusion-template-search // * visualeditor-dialog-transclusion-add-template label: ve.msg( dialogTitle ), help: ve.msg( 'visualeditor-dialog-transclusion-template-search-help' ), - helpInline: true, - // TODO: remove this line when templateSearchImprovements are out of beta - items: [].concat( [ feedbackMessage ], addTemplateFieldsetConfig.items ) + helpInline: true } ); } this.addTemplateFieldset = new OO.ui.FieldsetLayout( addTemplateFieldsetConfig );