wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not add empty <figcaption> to <figure> tag

Browse source 
Change-Id: I7527f88e05318bfa6f0dbd5663294e7f0dd31a3e
This commit is contained in:
Inez Korczyński 2013-06-24 17:22:03 -07:00
parent 12bd0ab325
commit 58d752331e
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
modules/ve/dm/nodes/ve.dm.MWBlockImageNode.js
View file

@ -117,7 +117,8 @@ ve.dm.MWBlockImageNode.static.toDomElements = function ( data, doc, converter )
img = doc.createElement( 'img' ),
wrapper = doc.createElement( 'div' ),
classes = [],
originalClasses = dataElement.attributes.originalClasses;
originalClasses = dataElement.attributes.originalClasses,
captionData = data.slice( 1, -1 );
// Type
switch ( dataElement.attributes.type ) {
@ -166,9 +167,13 @@ ve.dm.MWBlockImageNode.static.toDomElements = function ( data, doc, converter )
figure.appendChild( a );
a.appendChild( img );
converter.getDomSubtreeFromData( data.slice( 1, -1 ), wrapper );
while ( wrapper.firstChild ) {
figure.appendChild( wrapper.firstChild );
// If length of captionData is smaller or equal to 2 it means that there is no caption or that
// it is empty - in both cases we are going to skip appending <figcaption>.
if ( captionData.length > 2 ) {
converter.getDomSubtreeFromData( data.slice( 1, -1 ), wrapper );
while ( wrapper.firstChild ) {
figure.appendChild( wrapper.firstChild );
}
}
return [ figure ];
};