diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js index def58298ac..10366ecd2a 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js +++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js @@ -109,7 +109,6 @@ ve.init.mw.ViewPageTarget = function VeInitMwViewPageTarget() { 'showChanges': 'onShowChanges', 'showChangesError': 'onShowChangesError', 'noChanges': 'onNoChanges', - 'serializeComplete': 'onSerializeComplete', 'serializeError': 'onSerializeError', 'sanityCheckComplete': 'updateToolbarSaveButtonState' } ); @@ -593,20 +592,6 @@ ve.init.mw.ViewPageTarget.prototype.onShowChanges = function ( diffHtml ) { this.saveDialog.setDiffAndReview( diffHtml ); }; -/** - * Handle Serialize event. - * - * @method - * @param {string} wikitext - */ -ve.init.mw.ViewPageTarget.prototype.onSerializeComplete = function ( wikitext ) { - // Invalidate the viewer wikitext on next change - this.surface.getModel().getDocument().once( 'transact', - ve.bind( this.saveDialog.clearDiff, this.saveDialog ) - ); - this.saveDialog.setDiffAndReview( $( '
' ).text( wikitext ) ); -}; - /** * Handle failed show changes event. * @@ -780,13 +765,27 @@ ve.init.mw.ViewPageTarget.prototype.onSaveDialogReview = function () { // Has no callback, handled via target.onShowChanges this.showChanges( this.docToSave ); } else { - this.serialize( this.docToSave, ve.bind( this.onSerialize, this ) ); + this.serialize( this.docToSave, ve.bind( this.onSaveDialogReviewComplete, this ) ); } } else { this.saveDialog.swapPanel( 'review' ); } }; +/** + * Handle completed serialize request for diff views for new page creations. + * + * @method + * @param {string} wikitext + */ +ve.init.mw.ViewPageTarget.prototype.onSaveDialogReviewComplete = function ( wikitext ) { + // Invalidate the viewer wikitext on next change + this.surface.getModel().getDocument().once( 'transact', + ve.bind( this.saveDialog.clearDiff, this.saveDialog ) + ); + this.saveDialog.setDiffAndReview( $( '' ).text( wikitext ) ); +}; + /** * Try to save the current document. * @fires saveInitiated