From 1bbf7c339495e894238dc403a90bb4f11465b972 Mon Sep 17 00:00:00 2001 From: Thiemo Kreuz Date: Fri, 16 Jul 2021 11:50:40 +0200 Subject: [PATCH] Fix ellipsis on long strings in parameter search widget This ellipsis was there before we started working on this code, but was never working properly. We understand that the CSS was intentionally done like this (as the comment explains). However: * We changed the width of the dialog. The old value doesn't match any more. * The width is different when the sidebar is expanded vs. when it is collapsed. Even if we update the number, it won't always work. * The 100% work fine in current browsers. I can only assume this was different back in 2014 when this CSS was written (see Ia8259e9). Bug: T285044 Change-Id: I3de2b0ed0b6a05d2b9fa0b325a2b12277564b271 --- .../ui/styles/widgets/ve.ui.MWMoreParametersResultWidget.css | 3 +-- .../ve-mw/ui/styles/widgets/ve.ui.MWParameterResultWidget.css | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWMoreParametersResultWidget.css b/modules/ve-mw/ui/styles/widgets/ve.ui.MWMoreParametersResultWidget.css index 4fc8235e08..bd4bb66395 100644 --- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWMoreParametersResultWidget.css +++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWMoreParametersResultWidget.css @@ -22,8 +22,7 @@ white-space: nowrap; text-overflow: ellipsis; overflow: hidden; - /* HACK: Based on the expected width of this widget, using % produces unreliable results */ - max-width: 33em; + max-width: 100%; font-weight: bold; float: left; } diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWParameterResultWidget.css b/modules/ve-mw/ui/styles/widgets/ve.ui.MWParameterResultWidget.css index cc79823936..f01d944b40 100644 --- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWParameterResultWidget.css +++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWParameterResultWidget.css @@ -24,8 +24,7 @@ white-space: nowrap; text-overflow: ellipsis; overflow: hidden; - /* HACK: Based on the expected width of this widget, using % produces unreliable results */ - max-width: 33em; + max-width: 100%; } .ve-ui-mwParameterResultWidget-label {