wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Fix "null is not a string" error in event logging code"

Browse source
This commit is contained in:
jenkins-bot 2022-07-28 10:41:15 +00:00 committed by Gerrit Code Review
parent 15c56b442c cf77557a95
commit 52c155f43f
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
View file

@ -392,8 +392,10 @@ ve.ui.MWTemplateDialog.prototype.getActionProcess = function ( action ) {
} }
var parts = dialog.transclusionModel.getParts(); var parts = dialog.transclusionModel.getParts();
for ( var i = 0; i < parts.length; i++ ) { for ( var i = 0; i < parts.length; i++ ) {
if ( parts[ i ].getTitle ) { // Only {@see ve.dm.MWTemplateModel} have a title
templateEvent.template_names.push( parts[ i ].getTitle() ); var title = parts[ i ].getTitle && parts[ i ].getTitle();
if ( title ) {
templateEvent.template_names.push( title );
} }
} }
mw.track( 'event.VisualEditorTemplateDialogUse', templateEvent ); mw.track( 'event.VisualEditorTemplateDialogUse', templateEvent );