wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-27 12:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Proper support for frame images (do not display magnify icon)."

Browse source
This commit is contained in:
jenkins-bot 2013-06-06 03:26:49 +00:00 committed by Gerrit Code Review
parent 760470ab38 a9812ad4c6
commit 507a61bfd5
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
modules/ve/ce/nodes/ve.ce.MWImageCaptionNode.js
View file

@ -37,19 +37,26 @@ ve.ce.MWImageCaptionNode.static.tagName = 'div';
/* Methods */
/**
* TODO: Magnify should not be built nor appended if this is a caption of frame (vs. thumb) image.
* TODO: Magnify should appear/disappear based on the changes/updates to the parent (switching to
* and from thumb or frame).
*/
ve.ce.MWImageCaptionNode.prototype.onSplice = function () {
if ( this.$magnify ) {
this.$magnify.detach();
} else {
this.buildMagnify();
var parentType = this.model.getParent().getAttribute( 'type' );
if ( parentType === 'thumb' ) {
if ( this.$magnify ) {
this.$magnify.detach();
} else {
this.buildMagnify();
}
}
// Call parent implementation
ve.ce.BranchNode.prototype.onSplice.apply( this, arguments );
this.$magnify.prependTo( this.$ );
if ( parentType === 'thumb' ) {
this.$magnify.prependTo( this.$ );
}
};
ve.ce.MWImageCaptionNode.prototype.buildMagnify = function() {