wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-14 10:04:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't set a ParameterPage as next selection after delete

Browse source 
This can only happen when deleting the last part of a transclusion,
then we want to set the previous page as selected. This should never
be a parameter though.

Bug: T312221
Change-Id: I06700dcf37f6d4f7dd073f8f2bc1b8b0a17a62c4
This commit is contained in:
WMDE-Fisch 2022-07-12 13:35:34 +02:00
parent ec522938b8
commit 5067a1e216
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
modules/ve-mw/ui/layouts/ve.ui.MWTwoPaneTransclusionDialogLayout.js
View file

@ -299,9 +299,10 @@ ve.ui.MWTwoPaneTransclusionDialogLayout.prototype.removePages = function ( pages
isCurrentPageRemoved = true;
}
} else {
if ( !isCurrentPageRemoved ) {
// avoid choosing a parameter as previous selection
if ( !isCurrentPageRemoved && pageName.indexOf( '/' ) === -1 ) {
prevSelectionCandidate = pageName;
} else if ( !nextSelectionCandidate ) {
} else if ( isCurrentPageRemoved && !nextSelectionCandidate ) {
nextSelectionCandidate = pageName;
}
}