wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 19:26:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make ve.dm.Surface.{start,stop}HistoryTracking idempotent.

Browse source 
Add a little robustness, guaranteeing that we don't end up with multiple
history tracking tasks running, leaking one, or try to clear a non-running
interval.

Change-Id: I41db2d6fefc7f45f150aa14ecefc648760ad6200
This commit is contained in:
C. Scott Ananian 2013-08-27 09:31:26 -04:00 committed by Roan Kattouw
parent 3f7761d242
commit 4fee78227d
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
modules/ve/dm/ve.dm.Surface.js
View file

@ -101,7 +101,9 @@ ve.dm.Surface.prototype.startHistoryTracking = function () {
if ( !this.enabled ) {
return;
}
this.historyTrackingInterval = setInterval( ve.bind( this.breakpoint, this ), 750 );
if ( this.historyTrackingInterval === null ) {
this.historyTrackingInterval = setInterval( ve.bind( this.breakpoint, this ), 750 );
}
};
/**
@ -113,7 +115,10 @@ ve.dm.Surface.prototype.stopHistoryTracking = function () {
if ( !this.enabled ) {
return;
}
clearInterval( this.historyTrackingInterval );
if ( this.historyTrackingInterval !== null ) {
clearInterval( this.historyTrackingInterval );
this.historyTrackingInterval = null;
}
};
/**