From 4fc5d964db565dc848ef88cc444b14675c4cbc86 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartosz=20Dziewo=C5=84ski?= <matma.rex@gmail.com>
Date: Wed, 29 Jan 2020 11:14:16 -0800
Subject: [PATCH] ArticleTargetLoader: Fix loading visual diffs when no
 RESTBase

When mw.libs.ve.diffLoader#fetchRevision was calling this method, we
were accidentally making no query at all if RESTBase wasn't in use.

Change-Id: Ia98343aa1ba7f4f3be0c1a8ee5864653c429fb82
---
 modules/ve-mw/preinit/ve.init.mw.ArticleTargetLoader.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/ve-mw/preinit/ve.init.mw.ArticleTargetLoader.js b/modules/ve-mw/preinit/ve.init.mw.ArticleTargetLoader.js
index 53e8713887..8d21335e56 100644
--- a/modules/ve-mw/preinit/ve.init.mw.ArticleTargetLoader.js
+++ b/modules/ve-mw/preinit/ve.init.mw.ArticleTargetLoader.js
@@ -243,7 +243,7 @@
 				data.oldid = options.oldId;
 				apiXhr = new mw.Api().post( data );
 			} else {
-				if ( noMetadata ) {
+				if ( useRestbase && noMetadata ) {
 					apiPromise = $.Deferred().resolve( { visualeditor: {} } ).promise();
 				} else {
 					apiXhr = new mw.Api().get( data );