wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 19:26:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

MWLanguageVariantInspector: Use 'title' config option instead of 'iconTitle'

Browse source 
This way the tooltip is shown on the entire button, rather than only
on the icon. One should only use 'iconTitle' to display a different
tooltip on the icon than on the rest of the widget.

I think this was caused by bad documentation in OOUI, which I'm fixing
in I967d9b78014b3754720e80da9c4785124fffc2ba.

Change-Id: I8cc99bcfca56b80a8c8aff609ba48eb3f9c5ed7f
This commit is contained in:
Bartosz Dziewoński 2018-06-15 00:04:06 +02:00 committed by Jforrester
parent c04e934361
commit 4ee35de02a
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/ve-mw/ui/inspectors/ve.ui.MWLanguageVariantInspector.js
View file

@ -623,7 +623,7 @@ ve.ui.MWLanguageVariantTwoWayInspector.prototype.createItem = function ( lang, c
) );
clearButton = new OO.ui.ButtonInputWidget( {
icon: 'clear',
iconTitle: OO.ui.deferMsg(
title: OO.ui.deferMsg(
'visualeditor-mwlanguagevariantinspector-twoway-clear-button'
),
framed: false
@ -777,7 +777,7 @@ ve.ui.MWLanguageVariantOneWayInspector.prototype.createItem = function ( from, l
) );
clearButton = new OO.ui.ButtonInputWidget( {
icon: 'clear',
iconTitle: OO.ui.deferMsg(
title: OO.ui.deferMsg(
'visualeditor-mwlanguagevariantinspector-oneway-clear-button'
),
framed: false