wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-27 04:06:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Expand recursive call protection in ve.ui.Window#close

Browse source 
Focussing the view leads to another call of 'close' which
must be protected against.

Bug: 50140
Change-Id: I8c68468a95cddbc7efb222cf3a1f9868b2949285
This commit is contained in:
Ed Sanders 2013-06-26 13:58:35 +01:00
parent ac8d5eccb2
commit 4e728ebf26
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/ve/ui/ve.ui.Window.js
View file

@ -326,10 +326,12 @@ ve.ui.Window.prototype.close = function ( action ) {
this.$.hide();
this.visible = false;
this.onClose( action );
this.closing = false;
this.frame.$content.find( ':focus' ).blur();
this.surface.getView().focus();
this.emit( 'close', action );
// Note that focussing the surface view calls an on focus event, which in turn will
// try to close the window again, hence we put this.closing = false right at the bottom
this.closing = false;
}
};