wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-25 06:46:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Improve input widget value sanitization"

Browse source
This commit is contained in:
jenkins-bot 2013-06-11 19:47:34 +00:00 committed by Gerrit Code Review
parent f41045c51e 6a3badfcc7
commit 4d664cbeb6
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
modules/ve/ui/widgets/ve.ui.InputWidget.js
View file

@ -27,16 +27,17 @@ ve.ui.InputWidget = function VeUiInputWidget( config ) {
// Properties
this.$input = this.getInputElement( config );
this.value = config.value === undefined ? '' : config.value;
this.value = '';
this.readonly = false;
// Events
this.$input.on( 'keydown mouseup cut paste change input select', ve.bind( this.onEdit, this ) );
// Initialization
this.$input.attr( 'name', config.name ).val( this.value );
this.$input.attr( 'name', config.name );
this.setReadOnly( config.readOnly );
this.$.addClass( 've-ui-inputWidget' ).append( this.$input );
this.setValue( config.value );
};
/* Inheritance */
@ -118,7 +119,7 @@ ve.ui.InputWidget.prototype.setValue = function ( value ) {
this.value = value;
// Only update the DOM if we must
if ( domValue !== this.value ) {
this.$input.val( this.value );
this.$input.val( value );
}
this.emit( 'change', this.value );
}
@ -128,12 +129,14 @@ ve.ui.InputWidget.prototype.setValue = function ( value ) {
/**
* Sanitize incoming value.
*
* Ensures value is a string, and converts undefined and null to empty strings.
*
* @method
* @param {string} value Original value
* @returns {string} Sanitized value
*/
ve.ui.InputWidget.prototype.sanitizeValue = function ( value ) {
return String( value );
return value === undefined || value === null ? '' : String( value );
};
/**