wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-25 06:46:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make getDomText() return an empty string for slugs

Browse source 
Slugs aren't represented in the model at all, but in the DOM they do
contain a single character (  or ), so we have to override
the return value of getDomText() to be empty.

Change-Id: Ic93cb694b0632bc81d8d0749149e4d739232ed48
This commit is contained in:
Catrope 2012-10-01 11:37:39 -07:00
parent d9570ed0e5
commit 40b60ebda8
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
modules/ve/ce/ve.ce.js
View file

@ -47,14 +47,19 @@ ve.ce.getDomText = function ( element ) {
$element = $( element ); $element = $( element );
if ( nodeType === 1 || nodeType === 9 || nodeType === 11 ) { if ( nodeType === 1 || nodeType === 9 || nodeType === 11 ) {
if ( $element.hasClass( 've-ce-leafNode' ) ) { if ( $element.hasClass( 've-ce-slug' ) ) {
// Slugs are not represented in the model at all, but they do
// contain a single nbsp/FEFF character in the DOM, so make sure
// that character isn't counted
return '';
} else if ( $element.hasClass( 've-ce-leafNode' ) ) {
// For leaf nodes, don't return the content, but return // For leaf nodes, don't return the content, but return
// the right amount of characters so the offsets match up // the right amount of characters so the offsets match up
numChars = $element.data( 'node' ).getOuterLength(); numChars = $element.data( 'node' ).getOuterLength();
return new Array( numChars + 1 ).join( '\u2603' ); return new Array( numChars + 1 ).join( '\u2603' );
} else { } else {
// Traverse its children // Traverse its children
for ( element = element.firstChild; element; element = element.nextSibling) { for ( element = element.firstChild; element; element = element.nextSibling ) {
text += func( element ); text += func( element );
} }
} }