wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-14 10:04:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Optimize .selectPartById() to fire less events"

Browse source
This commit is contained in:
jenkins-bot 2021-09-15 09:07:18 +00:00 committed by Gerrit Code Review
parent 8ca4f2cc36 e62b3fecbb
commit 3b78f40e7a
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineContainerWidget.js
View file

@ -153,10 +153,17 @@ ve.ui.MWTransclusionOutlineContainerWidget.prototype.addPartWidget = function (
* parameter ids like "part_1/param1".
*/
ve.ui.MWTransclusionOutlineContainerWidget.prototype.selectPartById = function ( partId ) {
var changed = false;
for ( var id in this.partWidgets ) {
this.partWidgets[ id ].setSelected( id === partId );
var selected = id === partId;
if ( this.partWidgets[ id ].isSelected() !== selected ) {
this.partWidgets[ id ].setSelected( selected );
changed = true;
}
}
if ( changed ) {
this.emit( 'updateOutlineControlButtons', partId );
}
this.emit( 'updateOutlineControlButtons', partId );
};
/**