wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 11:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reposition context menu after rerender

Browse source 
Add rerender event to all image loads in MWExtensioNode.
MWHieroNode's implementation of onParseSuccess is now the same as
its parent so can be deleted.

Change-Id: Iaa4999372f1ba88a7bdf1490fc3f8640af77ceae
This commit is contained in:
Ed Sanders 2013-08-15 10:43:31 +01:00
parent 6fb65ec3a1
commit 37b461fe56
3 changed files with 6 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/ve-mw/ce/nodes/ve.ce.MWExtensionNode.js
View file

@ -82,6 +82,10 @@ ve.ce.MWExtensionNode.prototype.generateContents = function () {
ve.ce.MWExtensionNode.prototype.onParseSuccess = function ( deferred, response ) {
var data = response.visualeditor, contentNodes = $( data.content ).get();
deferred.resolve( contentNodes );
// Rerender after images load
this.$.find( 'img' ).on( 'load', ve.bind( function () {
this.emit( 'rerender' );
}, this ) );
};
/**

12
modules/ve-mw/ce/nodes/ve.ce.MWHieroNode.js
View file

@ -33,18 +33,6 @@ ve.ce.MWHieroNode.static.name = 'mwHiero';
ve.ce.MWHieroNode.static.tagName = 'div';
/* Methods */
/** */
ve.ce.MWHieroNode.prototype.onParseSuccess = function ( deferred, response ) {
var data = response.visualeditor, contentNodes = $( data.content ).get();
deferred.resolve( contentNodes );
// Rerender after image load
this.$.find( 'img' ).on( 'load', ve.bind( function () {
this.emit( 'rerender' );
}, this ) );
};
/* Registration */
ve.ce.nodeFactory.register( ve.ce.MWHieroNode );

2
modules/ve/ce/ve.ce.FocusableNode.js
View file

@ -106,6 +106,8 @@ ve.ce.FocusableNode.prototype.onFocusableResize = function () {
ve.ce.FocusableNode.prototype.onFocusableRerender = function () {
if ( this.focused ) {
this.redrawHighlight();
// reposition menu
this.surface.getSurface().getContext().show( true );
}
};